Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Contributing to the JavaScript SDK edit page not found #4451

Open
RafaelJCamara opened this issue Dec 3, 2024 · 3 comments
Open

Contributing to the JavaScript SDK edit page not found #4451

RafaelJCamara opened this issue Dec 3, 2024 · 3 comments

Comments

@RafaelJCamara
Copy link
Contributor

Describe the bug
When you try to edit this page: https://docs.dapr.io/contributing/sdk-contrib/js-contributing/

You get a 404:
image

Route to: https://github.com/dapr/docs/edit/v1.14/daprdocs/content/en/contributing/sdk-contrib/js-contributing.md

Steps to reproduce
Go to: https://docs.dapr.io/contributing/sdk-contrib/js-contributing/
Click on: Edit this page

Expected behavior
Route to: https://github.com/dapr/js-sdk/edit/main/daprdocs/content/en/js-sdk-contributing/js-contributing.md

@hhunter-ms
Copy link
Collaborator

@RafaelJCamara the SDK docs are pulled into dapr/docs as submodules. To edit SDK docs, you need to work from that SDK repo. So for this scenario, you can edit the JavaScript SDK contributing guide here in the dapr/js-sdk repo: https://github.com/dapr/js-sdk/blob/main/daprdocs/content/en/js-sdk-contributing/js-contributing.md

@hhunter-ms hhunter-ms self-assigned this Dec 3, 2024
@RafaelJCamara
Copy link
Contributor Author

I know, but for some edit links it routes correctly to the js-sdk docs, in some no.
I just wanted to raise awareness for that.

@hhunter-ms
Copy link
Collaborator

@RafaelJCamara Ahh thank you, I misunderstood. This is a good catch!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants