Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Uninstall dappnode and Exit if dappnode_install.sh fails #312

Open
4 tasks done
pablomendezroyo opened this issue Jul 6, 2021 · 5 comments · May be fixed by #342
Open
4 tasks done

Uninstall dappnode and Exit if dappnode_install.sh fails #312

pablomendezroyo opened this issue Jul 6, 2021 · 5 comments · May be fixed by #342
Assignees
@pablomendezroyo
Labels
installer This issue is related to the installer

Comments

@pablomendezroyo
Copy link
Contributor

pablomendezroyo commented Jul 6, 2021 •
edited by sync-by-unito bot
Loading

If the script dappnode_install.sh fails during dappnode installation, the process will continue even if any of the step has failed. This behaviour is not ideal and there should be a fallback process in case the script fails.

Consider:

  • Add set -e at the beginning of the script and print the error to the user
  • Download dappnode_uninstall.sh at the beggining of the script
  • Call dappnode_uninstall.sh in case there was any error
  • Ask the user to fix the issue depending on the error and rerun the script

┆Issue is synchronized with this Basecamp todo by Unito
@dapplion
Copy link
Contributor

dapplion commented Jul 6, 2021

At least this would be nice

Add set -e at the beginning of the script and print the error to the user

@pablomendezroyo pablomendezroyo transferred this issue from dappnode/DAppNode_Installer Jul 15, 2021
@pablomendezroyo pablomendezroyo added the installer This issue is related to the installer label Jul 15, 2021
@pablomendezroyo pablomendezroyo linked a pull request Aug 25, 2021 that will close this issue
[ ON HOLD] Uninstall dappnode on error #342
Draft
@stale
Copy link

stale bot commented Oct 24, 2021

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions!

@stale stale bot added the bot:stale label Oct 24, 2021
@stale
Copy link

stale bot commented Dec 25, 2021

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions!

@stale stale bot added the bot:stale label Dec 25, 2021
@stale
Copy link

stale bot commented Mar 19, 2022

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions!

@stale stale bot added the bot:stale label Mar 19, 2022
@alexpeterson91
Copy link
Member

Keep open

@stale stale bot removed the bot:stale label Mar 19, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@pablomendezroyo pablomendezroyo

Labels
installer This issue is related to the installer
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

[ ON HOLD] Uninstall dappnode on error dappnode/DAppNode
3 participants
@alexpeterson91 @dapplion @pablomendezroyo