Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adjust XCM weights; Disable force transfer #245

Merged
merged 7 commits into from
Nov 29, 2023
Merged

Adjust XCM weights; Disable force transfer #245

merged 7 commits into from
Nov 29, 2023

Conversation

F3Joule
Copy link
Member

@F3Joule F3Joule commented Nov 28, 2023

Release Checklist

  • Verify spec_version has been incremented since the last release.
  • Verify pallet and extrinsic ordering has stayed the same. Bump transaction_version if not.
  • Verify new extrinsics have been correctly whitelisted/blacklisted for BaseCallFilter
  • There are benchmarks for newly created extrinsics
  • Verify weights have been updated for any modified runtime logic.
  • There are tests for newly created logic
  • All the tests pass.
  • Ensure migrations run correctly

@F3Joule F3Joule self-assigned this Nov 28, 2023
@F3Joule F3Joule added the enhancement New feature or request label Nov 28, 2023
@F3Joule F3Joule marked this pull request as ready for review November 28, 2023 17:31
scripts/run-benchmark-on.sh Outdated Show resolved Hide resolved
@siman siman self-requested a review November 29, 2023 02:41
@F3Joule
Copy link
Member Author

F3Joule commented Nov 29, 2023

Extrinsics ordering check (metadata comparison):

Metadata comparison:
Date: Wed 29 Nov 2023 08:36:04 EET
Reference: wss://para.subsocial.network
Target version: subsocial-collator 0.2.0-50ae1082e12
Chain: dev
----------------------------------------------------------------------
              [Spec] name: subsocial-parachain
                     spec_version: 32 -> 33
                     transaction_version: 6
          [Metadata] version: 14
           [Modules] num: 33
                          [System] idx: 0 (calls: 8, storage: 17)
                 [ParachainSystem] idx: 1 (calls: 4, storage: 22)
                       [Timestamp] idx: 3 (calls: 1, storage: 3)
                        [Balances] idx: 10 (calls: 6, storage: 6)
               [CollatorSelection] idx: 21 (calls: 5, storage: 6)
                         [Session] idx: 22 (calls: 2, storage: 8)
                         [Vesting] idx: 26 (calls: 5, storage: 3)
                           [Proxy] idx: 27 (calls: 10, storage: 3)
                       [XcmpQueue] idx: 30 (calls: 9, storage: 11)
                     [PolkadotXcm] idx: 31 (calls: 10, storage: 12)
                        [DmpQueue] idx: 33 (calls: 1, storage: 6)
                         [Domains] idx: 60 (calls: 9, storage: 8)
                          [Energy] idx: 61 (calls: 2, storage: 4)
                       [FreeProxy] idx: 62 (calls: 1, storage: 2)
                  [CreatorStaking] idx: 63 (calls: 13, storage: 13)
                           [Roles] idx: 71 (calls: 8, storage: 6)
                  [AccountFollows] idx: 72 (calls: 3, storage: 4)
                        [Profiles] idx: 73 (calls: 3, storage: 2)
                    [SpaceFollows] idx: 74 (calls: 3, storage: 4)
                  [SpaceOwnership] idx: 75 (calls: 3, storage: 2)
                          [Spaces] idx: 76 (calls: 4, storage: 4)
                           [Posts] idx: 77 (calls: 6, storage: 6)
                       [Reactions] idx: 78 (calls: 6, storage: 5)
                            [Sudo] idx: 255 (calls: 4, storage: 2)

------------------------------ SUMMARY ------------------------------- 
⚠️ This filter is here to help spotting changes that should be reviewed carefully. 
⚠️ It catches only index changes, deletions and value decreases. 
## Deletions
 n/a 
## Index changes
 n/a 
## Decreases
 n/a 
----------------------------------------------------------------------

@siman siman changed the title Adjust XCM weights Adjust XCM weights; Disable force transfer Nov 29, 2023
@F3Joule F3Joule merged commit 292a919 into main Nov 29, 2023
2 checks passed
@F3Joule F3Joule deleted the f3/adjust-weights branch November 29, 2023 10:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants