Change naming of attribute to use hard navigation

dappforce · Mar 5, 2024 · b9ec8f4 · b9ec8f4
1 parent 4d97e23
commit b9ec8f4
Show file tree

Hide file tree

Showing 3 changed files with 7 additions and 6 deletions.
diff --git a/src/components/referral/CustomLink.tsx b/src/components/referral/CustomLink.tsx
@@ -1,4 +1,5 @@
 import Link, { LinkProps } from 'next/link'
+import { ComponentProps } from 'react'
 import urlJoin from 'src/utils/url-join'
 import { useReferralId } from './ReferralUrlChanger'
 
@@ -7,7 +8,7 @@ function getCurrentUrlOrigin() {
   return window.location.origin
 }
 
-export default function CustomLink(props: React.PropsWithChildren<LinkProps>) {
+export default function CustomLink(props: ComponentProps<typeof Link>) {
   const refId = useReferralId()
   if (refId) {
     props = {

diff --git a/src/layout/SideMenu.tsx b/src/layout/SideMenu.tsx
@@ -8,7 +8,7 @@ import { buildAuthorizedMenu, isDivider, PageLink } from './SideMenuItems'
 import styles from './Sider.module.sass'
 
 const renderPageLink = (item: PageLink) => {
-  const { icon, openInNewTab, toExternalLink } = item
+  const { icon, openInNewTab, forceHardNavigation } = item
 
   if (item.hidden) {
     return null
@@ -24,7 +24,7 @@ const renderPageLink = (item: PageLink) => {
 
   return (
     <Menu.Item className='DfMenuItem' key={item.href}>
-      {toExternalLink ? (
+      {forceHardNavigation ? (
         <a {...anchorProps} href={item.href}>
           <span className='MenuItemIcon'>{icon}</span>
           <span className='MenuItemName'>{item.name}</span>

diff --git a/src/layout/SideMenuItems.tsx b/src/layout/SideMenuItems.tsx
@@ -17,7 +17,7 @@ export type PageLink = {
   icon: React.ReactNode
   hidden?: boolean
   openInNewTab?: boolean
-  toExternalLink?: boolean
+  forceHardNavigation?: boolean
 
   // Helpers
   isNotifications?: boolean
@@ -40,7 +40,7 @@ export const buildAuthorizedMenu = (myAddress?: string): MenuItem[] => {
       name: 'Chat',
       icon: <SubIcon Icon={BiChat} />,
       href: '/c/chats',
-      toExternalLink: true,
+      forceHardNavigation: true,
     },
     ...(myAddress
       ? [
@@ -56,7 +56,7 @@ export const buildAuthorizedMenu = (myAddress?: string): MenuItem[] => {
       name: 'Content Staking',
       icon: <SubIcon Icon={TbCoins} />,
       href: '/c/staking',
-      toExternalLink: true,
+      forceHardNavigation: true,
     },
     {
       name: 'Leaderboard',