Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Minor Fixes #357

Merged
merged 8 commits into from
Aug 28, 2023
Merged

Minor Fixes #357

merged 8 commits into from
Aug 28, 2023

Conversation

teodorus-nathaniel
Copy link
Contributor

@teodorus-nathaniel teodorus-nathaniel commented Aug 28, 2023

Fixes

  • Only use react-tweet embed for tweet link, not any twitter link
  • Fix embed overflow (esp react-tweet in small screen)
  • If the link metadata's image is http, treat it like it has no image
  • Use react portal to render recaptcha (because we have errors regarding recaptcha CORS, this is how to solve it according to this article)
  • Add try catch for CID.parse, so it won't trigger client error exception if wrong cid was passed (potential cause of beef's error)
  • Fix textarea not expanding in edit chat modal
  • Make scroll to message button sticky to the bottom of the message container (message modal)
    after:
    image
    before:
    image

@teodorus-nathaniel teodorus-nathaniel self-assigned this Aug 28, 2023
@teodorus-nathaniel teodorus-nathaniel added the bug Something isn't working label Aug 28, 2023
@olehmell olehmell merged commit c7db413 into main Aug 28, 2023
2 checks passed
@teodorus-nathaniel teodorus-nathaniel deleted the deploy/fixes branch November 9, 2023 16:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants