Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

AlchemyExperimental - PluginManager (schemeFactory) #1750

Closed
4 tasks done
orenyodfat opened this issue May 26, 2020 · 6 comments
Closed
4 tasks done

AlchemyExperimental - PluginManager (schemeFactory) #1750

orenyodfat opened this issue May 26, 2020 · 6 comments
Labels

Comments

@orenyodfat
Copy link
Contributor

orenyodfat commented May 26, 2020

  • GenericScheme : we should enable user to choose custom target address , even though there is no custom UI for that.

  • Competition : The proposal should say it is a competition (not CRExt )

Screen Shot 2020-05-26 at 10 31 57

  • It will be nice to show the users the parameters the contract will be init with (not just the callData).

  • replace plugin : Why DAO factory appears on the list of plugins ?

@dOrgJelli
Copy link
Contributor

dOrgJelli commented May 26, 2020

  • ContributionRewardExt can have null rewarder (_daoFactory, _packageVersion, _rewarderName)
  • Adding Competition shows up as empty plugin?
  • Show only registered plugins in all dropdowns
  • Empty name in dropdown for competition plugin
  • Replace proposals show as Remove proposals

@dOrgJelli
Copy link
Contributor

Competition : The proposal should say it is a competition (not CRExt )

@orenyodfat, for this task, it requires decoding the initialize calldata. I've added it to the issue here: #1770

@dOrgJelli
Copy link
Contributor

ContributionRewardExt can have null rewarder (_daoFactory, _packageVersion, _rewarderName)

@orenyodfat since this requires changes in arc.js, I've created an issue here for this: daostack/arc.js#493

@orenyodfat orenyodfat reopened this Jun 1, 2020
@orenyodfat
Copy link
Contributor Author

ContributionRewardExt can have null rewarder (_daoFactory, _packageVersion, _rewarderName)

@orenyodfat since this requires changes in arc.js, I've created an issue here for this: daostack/arc.js#493

how it related to arc.js ? the rewarder is part of the schemeData which is passed to schemeFactory,..no ? https://github.com/daostack/arc/blob/arc-factory/contracts/schemes/SchemeFactory.sol#L112

@dOrgJelli
Copy link
Contributor

ContributionRewardExt can have null rewarder (_daoFactory, _packageVersion, _rewarderName)

@orenyodfat since this requires changes in arc.js, I've created an issue here for this: daostack/arc.js#493

how it related to arc.js ? the rewarder is part of the schemeData which is passed to schemeFactory,..no ? https://github.com/daostack/arc/blob/arc-factory/contracts/schemes/SchemeFactory.sol#L112

This interface will need to change, and the initializeParamsMap will need to change as well:
https://github.com/daostack/arc.js/blob/651c298c46df6edcbc0d2148244700ad15652d0c/src/plugins/contributionRewardExt/plugin.ts#L40

@orenyodfat
Copy link
Contributor Author

ContributionRewardExt can have null rewarder (_daoFactory, _packageVersion, _rewarderName)

@orenyodfat since this requires changes in arc.js, I've created an issue here for this: daostack/arc.js#493

how it related to arc.js ? the rewarder is part of the schemeData which is passed to schemeFactory,..no ? https://github.com/daostack/arc/blob/arc-factory/contracts/schemes/SchemeFactory.sol#L112

This interface will need to change, and the initializeParamsMap will need to change as well:
https://github.com/daostack/arc.js/blob/651c298c46df6edcbc0d2148244700ad15652d0c/src/plugins/contributionRewardExt/plugin.ts#L40

does passing a rewarded as 0x0000000000000000000000000000000000000000000000000000000000000000 will not work as is ?
@dOrgJelli

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants