Xcuitestrunner over tunnel (iOS 17) #301
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
diegoperini
changed the title
|
Hello @diegoperini does this works now? |
|
Any updates on this , i see when you try to start the webdriveragent it hangs, you have comment that piece of code there, that still to figure out. |
dmissmann
requested changes
Dec 12, 2023
| @@ -123,6 +123,33 @@ func NewConnection(device ios.DeviceEntry, serviceName string) (*Connection, err | |||
| return dtxConnection, nil | |||
| } | |||
|
|
|||
| // NewTunnelConnection connects and starts reading from a Dtx based service on the device, using tunnel interface instead of usbmuxd | |||
| func NewTunnelConnection(device ios.DeviceEntry, serviceName string) (*Connection, error) { | |||
| conn, err := ios.ConnectToServiceTunnelIface(device, serviceName) | |||
There was a problem hiding this comment.
everything except this line is a duplicate of NewLockdownConnection. This can be handled in a better way to have less duplication.
There was a problem hiding this comment.
DTX connection part is now under its own function.
diegoperini
changed the title
dmissmann
reviewed
Dec 13, 2023
|
@dmissmann I reviewed all info logs to see which ones can be debug logs instead. I also renamed stuff you point out in the review comments. Could you please take a second look to current state of the PR? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.