Fix/dtx panic (#130)

forgot to handle an error that would crash with a panic instead of warning that the developer image was missing
danielpaulus · Apr 23, 2022 · 204eb25 · 204eb25
1 parent 7878cad
commit 204eb25
Show file tree

Hide file tree

Showing 2 changed files with 8 additions and 2 deletions.
diff --git a/ios/dtx_codec/connection.go b/ios/dtx_codec/connection.go
@@ -40,8 +40,11 @@ type GlobalDispatcher struct {
 const requestChannel = "_requestChannelWithCode:identifier:"
 
 //Close closes the underlying deviceConnection
-func (dtxConn *Connection) Close() {
-	dtxConn.deviceConnection.Close()
+func (dtxConn *Connection) Close() error {
+	if dtxConn.deviceConnection != nil {
+		return dtxConn.deviceConnection.Close()
+	}
+	return nil
 }
 
 //GlobalChannel returns the connections automatically created global channel.

diff --git a/ios/testmanagerd/xcuitestrunner_11.go b/ios/testmanagerd/xcuitestrunner_11.go
@@ -22,6 +22,9 @@ func RunXCUIWithBundleIds11(
 	}
 	log.Debugf("test session setup ok")
 	conn, err := dtx.NewConnection(device, testmanagerd)
+	if err != nil {
+		return err
+	}
 	defer conn.Close()
 	ideDaemonProxy := newDtxProxyWithConfig(conn, testConfig)