This can be None

[drozzy]

data can be none (as set by the code within exception clause above).
This failed on me already.

unifi-protect-video-downloader/protect_archiver/downloader/download_file.py

Line 86 in 530299d

error_message = data.get("error") or data or "(no information available)"

[danielfernau]

Hi and thanks for reporting. You have created a PR but deleted it afterwards - is this issue still relevant and you just wanted to try something that didn't work? Let me know if you need me to have another look at it.

[drozzy]

I deleted that by mistake. But PR was just a single line change in download_file.py.
This:

try:
    data = json.loads(response.content)
except Exception:
    data = None

Becomes this:

try:
    data = json.loads(response.content)
except Exception:
    data = {}

[danielfernau]

Alright, yes, that makes sense. Will add it later and bundle an update. Thanks!