Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove glyphicon not shown when using with jQuery 3.5.1 #271

Open
daniel-rutten-clickwise-limited opened this issue May 8, 2020 · 3 comments
Labels
bug Confirmed bug

Comments

@daniel-rutten-clickwise-limited
Copy link

daniel-rutten-clickwise-limited commented May 8, 2020

I've just upgraded form jQuery 3.4.1 to 3.5.1 and the glyphicon-remove is no longer shown when I select from the drop down box. I think the problem is due to the way the template is defined (see the template function on line 181).

It looks like 3.4.1 used to translate

<span class="caret" /><span class="glyphicon glyphicon-remove" />

to

<span class="caret"></span><span class="glyphicon glyphicon-remove"></span>

but 3.5.1 turns that into

<span class="caret"><span class="glyphicon glyphicon-remove"></span></span>

Since the caret class is hidden when I select from the drop down box, the remove icon is hidden as wel.

I've fixed it for now by changing

<span class="caret" /><span class="glyphicon glyphicon-remove" />

into

<span class="caret"></span><span class="glyphicon glyphicon-remove"></span>

but I was wondering if anyone else has found this problem.

@tiesont
Copy link
Collaborator

tiesont commented May 9, 2020

Yeah, spans are not self-closing, so that's not really valid. I'll see if I can fix that sometime today or this weekend.

@tiesont tiesont added the bug Confirmed bug label May 9, 2020
@tiesont
Copy link
Collaborator

tiesont commented May 9, 2020

Related: https://jquery.com/upgrade-guide/3.5/#jquery-htmlprefilter-changes

@eeintech
Copy link

Thanks for that solution @danielrutten, works for me!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Confirmed bug
Projects
None yet
Development

No branches or pull requests

3 participants