Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Code doesn't compile in Delphi XE2 #51

Open
Eugene-Kovalsky opened this issue Jan 17, 2022 · 2 comments
Open

Code doesn't compile in Delphi XE2 #51

Eugene-Kovalsky opened this issue Jan 17, 2022 · 2 comments

Comments

@Eugene-Kovalsky
Copy link

TStringHelper appeared only in the XE3. Also {$IF} must be closed with {$IFEND} in XE2.
@danieleteti
Copy link
Owner

Thank you for your suggestions. We don't have XE2 anymore. Can you provide a PR o the changed units?

@Eugene-Kovalsky
Copy link
Author

I've corrected the code for some appenders and ThreadSafeQueueU.pas unit so that the samples compiles and work properly (I didn't check remote logging). I can send diff file, but Simple console appender sample contains ITask interface which appeared in XE7. Maybe remove the mention of support for XE2 from the description?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@danieleteti @Eugene-Kovalsky