Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Separate domains into separate folders #67

Closed
danielemery opened this issue Nov 2, 2023 · 0 comments · Fixed by #68
Closed

Separate domains into separate folders #67

danielemery opened this issue Nov 2, 2023 · 0 comments · Fixed by #68

Comments

@danielemery
Copy link
Owner

danielemery commented Nov 2, 2023 •
edited
Loading

In #66 a new statistics resolver and service is being introduced.

In order to keep the codebase tidy I'm proposing separating it into domains:

  • user
  • quiz
  • config
  • auth
  • files
  • statistics*

These will be the top level folders that will hold the resolvers, services, persistence layers, tests etc for each domain.

As things are being consolidated they could also be converted into classes that take dependencies as arguments to make testing easier later.
danielemery added a commit that referenced this issue Nov 2, 2023
@danielemery
#67 Move each file into a domain folder
f47efe4
danielemery added a commit that referenced this issue Nov 2, 2023
@danielemery
#67 Convert authorization and authentication services into DI classes
955b612
danielemery added a commit that referenced this issue Nov 2, 2023
@danielemery
#67 Convert s3 and sqs service into DI classes
6dce99e
danielemery added a commit that referenced this issue Nov 2, 2023
@danielemery
#67 Split quizResolver into graphql component and DI class
df04b1d
danielemery added a commit that referenced this issue Nov 2, 2023
@danielemery
#67 Split userResolver into graphql component and DI class
60d4240
danielemery added a commit that referenced this issue Nov 2, 2023
@danielemery
#67 Split models into scoped dto files
4a8abd5
danielemery added a commit that referenced this issue Nov 2, 2023
@danielemery
#67 Exclusively use dto types in gql definitions
4cc0c0a
danielemery added a commit that referenced this issue Nov 2, 2023
@danielemery
#67 Split persistence.ts into helpers, quiz, user and prisma components
29da37c
danielemery added a commit that referenced this issue Nov 3, 2023
@danielemery
#67 Fix binding issues
b2c37fd
@danielemery danielemery linked a pull request Nov 3, 2023 that will close this issue
Separate domains into separate folders #68
Merged
danielemery added a commit that referenced this issue Nov 3, 2023
@danielemery
#67 Inject dependencies wherever possible
a5f60b5
danielemery added a commit that referenced this issue Nov 3, 2023
@danielemery
Separate domains into separate folders (#68)
3a71c74 
* #67 Move each file into a domain folder
* #67 Convert authorization and authentication services into DI classes
* #67 Convert s3 and sqs service into DI classes
* #67 Split quizResolver into graphql component and DI class
* #67 Split userResolver into graphql component and DI class
* #67 Split models into scoped dto files
* #67 Exclusively use dto types in gql definitions
* #67 Split persistence.ts into helpers, quiz, user and prisma components
* #67 Fix binding issues
* #67 Inject dependencies wherever possible
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Separate domains into separate folders danielemery/quizlord-api
1 participant
@danielemery