Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix version injection #48

Closed
danielemery opened this issue Sep 24, 2023 · 0 comments · Fixed by #49
Closed

Fix version injection #48

danielemery opened this issue Sep 24, 2023 · 0 comments · Fixed by #49
Assignees
@danielemery
Labels
bug Something isn't working

Comments

@danielemery
Copy link
Owner

In #44 we missed the version injection that used to be done in the CircleCI job. This is causing the container to fail on startup.
@danielemery danielemery added the bug Something isn't working label Sep 24, 2023
@danielemery danielemery self-assigned this Sep 24, 2023
danielemery added a commit that referenced this issue Sep 24, 2023
@danielemery
#48 Include IMAGE_VERSION build argument
e96b735
danielemery added a commit that referenced this issue Sep 24, 2023
@danielemery
#48 Remove redundant debug build step
d0fb526
@danielemery danielemery linked a pull request Sep 24, 2023 that will close this issue
Hotfix to reimplement version injection in github actions #49
Merged
danielemery added a commit that referenced this issue Sep 24, 2023
@danielemery
Hotfix to reimplement version injection in github actions (#49)
557f78d 
* #48 Include IMAGE_VERSION build argument
* #48 Remove redundant debug build step
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@danielemery danielemery

Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Hotfix to reimplement version injection in github actions danielemery/quizlord-api
1 participant
@danielemery