Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

PHP-Parallel-Lint shorttags option #1339

Open
2 of 4 tasks
Dave13h opened this issue Aug 21, 2017 · 1 comment
Open
2 of 4 tasks

PHP-Parallel-Lint shorttags option #1339

Dave13h opened this issue Aug 21, 2017 · 1 comment

Comments

@Dave13h
Copy link
Contributor

Dave13h commented Aug 21, 2017

Before submitting your issue, please make sure that you've checked all of the checkboxes below.

  • You're running the latest release version of PHPCI.
  • Ensure that you're running at least PHP 5.3.6, you can check this by running php -v
  • You've run composer install --no-dev -o from the root of your installation.
  • You have set up either the PHPCI Worker, Daemon or Cron Job to run builds.

To help us better understand your issue, please answer the following.

Expected behaviour

There is no option to pass -s to php-parallel-lint, so even if the server supports php shorttags, the linter will fail if you use shorttags.

Actual behaviour

php-parallel-lint will fail with various php parse errors like unexpected end of file if you open an if statement in a <?php section (typically the opening line of the file?) and close it in a <? section.

Steps to reproduce

<?php
if (true): ?>
Hello PHPCI
<? endif; ?>

Environment info

Operating System: Debian GNU/Linux 7.11 (wheezy)
PHP Version: 5.6.31
MySQL Version: n/a

PR

#1338

@Gummibeer
Copy link

I think that this isn't a real issue - related to the php documentation these are removed in php-7.0.0 http://php.net/manual/en/language.basic-syntax.phptags.php
Cause of the fact that 5.6 and 7.0 are just in security phase and end of the year they are out of date it is bad practice to use short-tags any more.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants