Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

PHPCI Github status checks on PR #1288

Open
stephan-v opened this issue Dec 23, 2016 · 8 comments
Open

PHPCI Github status checks on PR #1288

stephan-v opened this issue Dec 23, 2016 · 8 comments

Comments

@stephan-v
Copy link

stephan-v commented Dec 23, 2016

I am wondering if it is possible get status checks for a pull request similar to what travis-ci and other services are doing:

status

This would help a lot since we don't constantly want to monitor the PHPCI server but rather just have our checks show up on pull requests.

Edit

I have noticed in the GithubBuild.php that there is a sendStatusPostback but I don't think anything happens with it curently. Does anybody know how I can enable this?

Seems like this also needs a token to work because it sets an Authorization token header. How can I check if a token has been set or not? Or how can I set up a token for my PHPCI app?

@ptejada
Copy link
Contributor

ptejada commented Dec 23, 2016 via email

@stephan-v
Copy link
Author

stephan-v commented Dec 23, 2016

You are not making a whole lot of sense. You mean to say that there is all this Github specific logic that needs a token but no documentation on how to add a token or some config option to add your own token?

Things like:
./console phpci:poll-github

Need an access token to work, yet there is no option to add a token. That is besides editing the config.yml manually, which you have to know just by digging through the code.

Even if you set the access token commands like poll-github still fail.

Am I suppose to fix these things by setting up oauth by going to:

Admin >> Settings >> GitHub Application ?

The url that the poll-github command uses also needs to know my username but I see no reference to my username in the code of 'HttpClient.php' which is used to build the polling url.

@ptejada
Copy link
Contributor

ptejada commented Dec 23, 2016 via email

@stephan-v
Copy link
Author

stephan-v commented Dec 23, 2016

I know it is probably possible at the moment since I have found it in the codebase, but it seems utterly broken at the moment. Is that correct?

My authentication settings under setttings also displays nothing but an empty checkbox with:

Disable Authentication?

Are there normally suppose to be some fields with authentication settings there as well? Perhaps name and personal access token?

@ptejada
Copy link
Contributor

ptejada commented Dec 23, 2016 via email

@stephan-v
Copy link
Author

stephan-v commented Dec 23, 2016

Travis-CI is too expensive for private repo's but thanks anyways. It's a shame the Github API functionally is practically non-existent now because nowhere are you asked for a personal access token, or oauth setup.

@ptejada
Copy link
Contributor

ptejada commented Dec 23, 2016 via email

@Fenikkusu
Copy link
Contributor

It does work, but it is a slight pain in the rear to get working it seems. On a lower level:

  1. Create a OAuth Integration
  2. Update config.yml to have a phpci:github section with the Integration OAuth token and id
  3. Setup a webhook that includes the permissions for pull requests as well as read permissions, etc.

Disclaimer Still working on this, but I do have it at least communicating to a certain degree.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants