Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

not opening #28

Closed
codegod100 opened this issue Apr 22, 2024 · 16 comments · Fixed by #142
Closed

not opening #28

codegod100 opened this issue Apr 22, 2024 · 16 comments · Fixed by #142
Labels

Comments

@codegod100
Copy link

codegod100 commented Apr 22, 2024

I built with wgpu and thought that was the issue then removed wgpu from config toml and it's using glow but still closes immediately with no errors and no window

running on debian 12

@jb55
Copy link
Contributor

jb55 commented Apr 22, 2024

can you show the output of RUST_LOG=debug cargo run

@jb55
Copy link
Contributor

jb55 commented May 12, 2024

I'm guessing this is related to

@hellodword
Copy link
Contributor

Same on intel laptop (nixos, sway):

$ RUST_LOG=debug cargo run
warning: field `warn_fg_color` is never read
  --> src/colors.rs:29:9
   |
23 | pub struct ColorTheme {
   |            ---------- field in this struct
...
29 |     pub warn_fg_color: Color32,
   |         ^^^^^^^^^^^^^
   |
   = note: `#[warn(dead_code)]` on by default

warning: `notedeck` (lib) generated 1 warning
    Finished `dev` profile [unoptimized + debuginfo] target(s) in 0.20s
     Running `target/debug/notedeck`
2024-05-15T15:15:03.640569Z  INFO eframe: Both the glow and wgpu renderers are available. Using wgpu.    
2024-05-15T15:15:03.640601Z DEBUG eframe: Using the wgpu renderer  

$ echo $?
0

@jb55
Copy link
Contributor

jb55 commented May 15, 2024

can you comment and uncomment these lines and see if it helps?

eframe = { version = "0.27.2", default-features = false, features = [ "glow", "wgpu", "android-native-activity" ] }
#eframe = { version = "0.27.2", default-features = false, features = [ "glow", "android-native-activity" ] }

@jb55
Copy link
Contributor

jb55 commented May 15, 2024

I have to do this on my nixos laptop with intel graphics, I haven't yet fixed

@hellodword
Copy link
Contributor

diff --git a/Cargo.toml b/Cargo.toml
index 97f2900..49ed728 100644
--- a/Cargo.toml
+++ b/Cargo.toml
@@ -14,8 +14,8 @@ crate-type = ["lib", "cdylib"]
 [dependencies]
 #egui-android = { git = "https://github.com/jb55/egui-android.git" }
 egui = "0.27.2"
-eframe = { version = "0.27.2", default-features = false, features = [ "glow", "wgpu", "android-native-activity" ] }
-#eframe = { version = "0.27.2", default-features = false, features = [ "glow", "android-native-activity" ] }
+#eframe = { version = "0.27.2", default-features = false, features = [ "glow", "wgpu", "android-native-activity" ] }
+eframe = { version = "0.27.2", default-features = false, features = [ "glow", "android-native-activity" ] }
 #eframe = "0.22.0"
 egui_extras = { version = "0.27.2", features = ["all_loaders"] }
 ehttp = "0.2.0"
$ git log --oneline -1
0d240c1 (HEAD -> master, upstream/master) simplify tab underline calculation

$ RUST_LOG=debug cargo run
    Finished `dev` profile [unoptimized + debuginfo] target(s) in 0.20s
     Running `target/debug/notedeck`
2024-05-16T02:09:36.779986Z DEBUG eframe: Using the glow renderer    

$ echo $?
0

No luck with the diff

@jb55
Copy link
Contributor

jb55 commented May 16, 2024

very weird... must be a wayland issue? I have not tested with wayland.

@hellodword
Copy link
Contributor

Ok then I will try X11 next.

BTW I noticed that egui supports web (Wasm and WebGL), is it possible for notedeck?

@hellodword
Copy link
Contributor

Still no luck on X11, in a new nixos vm, with the commit 0e0e5d0:

See: https://gist.github.com/hellodword/e368c8e07f4a661c4ed0281d117fc61d

@jb55
Copy link
Contributor

jb55 commented May 16, 2024 via email

@hellodword
Copy link
Contributor

Good idea, I'll try it tomorrow

@hellodword
Copy link
Contributor

It seems that I've fixed it on Sway, I'll push the changes (wayland) to #57

@jb55
Copy link
Contributor

jb55 commented May 18, 2024 via email

jb55 added a commit that referenced this issue Jul 3, 2024
There are some wgpu issues that are fixed in egui-master, so
let's switch to that.

This fixes notedeck so that it runs on both my intel graphics laptop
and amdgpu desktop.

Fixes: #28
Fixes: #42
Fixes: #141
Signed-off-by: William Casarin <[email protected]>
jb55 added a commit that referenced this issue Jul 3, 2024
There are some wgpu issues that are fixed in egui-master, so
let's switch to that.

This fixes notedeck so that it runs on both my intel graphics laptop
and amdgpu desktop.

Fixes: #28
Fixes: #42
Fixes: #141
Signed-off-by: William Casarin <[email protected]>
@jb55 jb55 closed this as completed in 239a2cb Jul 3, 2024
@jb55
Copy link
Contributor

jb55 commented Jul 3, 2024

wgpu has been updated, let me know if you still run into issues on wayland

@jb55 jb55 reopened this Jul 3, 2024
@jb55
Copy link
Contributor

jb55 commented Jul 3, 2024

I think there is a still a wayland issue

@jb55
Copy link
Contributor

jb55 commented Jul 3, 2024

nm tested it on debian and seems to be fine now

@jb55 jb55 closed this as completed Jul 3, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants