Add sharing option in image carousel view #2629
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The ellipsis (share button) allows you to share the current image being displayed in the full screen carousel viewer. Changelog-Changes: Add share button in Full screen image carousel view (for Image only) Signed-off-by: Swift Coder <[email protected]>
scoder1747
changed the title
The ellipsis (share button) allows you to share actual image from the full screen carousel viewer in timeline. Changelog-Changes: Share for actual image from Carousel Viewer Signed-off-by: Swift Coder <[email protected]>
scoder1747
force-pushed
the
add-share-button-in-full-screen-image-carousel
branch
from
218b4c3 to
47d99ac
Compare
|
Thank you @scoder1747! I will take a look soon |
|
Thank you @scoder1747! Changes look good, merged! |
2 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This PR adds an ellipsis (share button) to enable sharing in the full-screen carousel viewer. Tapping the button brings up a share sheet, allowing sharing via messaging and social media apps.
r12.mov
Updated - Sharing an actual image:
Checklist
Closes:orFixes:tags in the commit messages wherever applicable, or made sure those are not needed. See Submitting patches