feat(port): add nova #148
feat(port): add nova #148
Conversation
Removed code that was added during CLI troubleshooting
This reverts commit 4a929fd.
Removed code that was added during troubleshooting
|
@DanKlaver15 this red border color can be changed? If so, please update it to the green color as in vscode.
|
|
I looked but I wasn’t able to find anywhere to change it. Since Nova is still so new they are updating things like that all the time but their theming is still slightly barebones |
| ...colorSchemes.dark, | ||
| portName, | ||
| version, | ||
| hello: 'Hello from Aura!', |
There was a problem hiding this comment.
I think this should be removed, right?
| const version = '1.0.0' | ||
|
|
||
| await createPort({ | ||
| template: resolve(templateFolder, 'hello-aura.json'), |
There was a problem hiding this comment.
Please, remove the "hello-" in the filename.
|
|
||
| # Installation | ||
|
|
||
| 1. Open Nova Extension Library from Nova Extensions menu |
There was a problem hiding this comment.
Are the steps to install right? The compiled file in the packages folder is only the hello-aura.json that has only one color. In the src/ports folder template folder should have files that will be transformed by the template engine, and extra folder to files and folder that will be cloned as it is. Please, take a look at how I did it in the vscode port
If you need the final AuraTheme.novaextension be a zip file, take a look how I did it in the Telegram port
There was a problem hiding this comment.
I as following the instructions for creating a port which is why the aura.json file is in there. That file isn’t actually needed for the extension. Nova has it’s own extension store that I was going to submit to once you approved the port. AuraTheme.novaextension just needs to be submitted to the Nova extensions and then users can access it from within the App, kind of live VS code. How would you like me to proceed?
There was a problem hiding this comment.
@DanKlaver15 In general, it's important that no theme depends on the store (even if it will be published later), we need to make use of the Aura generator in case any color or color tone changes the change is done in bulk without effort, this is only possible if we follow the creation based on the generator that will translate the tokens. Take a look at how vscode port was made, please.
As for in-store publishing, this is a dilemma for me. I currently prefer official themes to be put in stores by me, if you don't mind. Opening official publications in stores can generate some problems, such as, for example, an update in Aura depends on the author of the port, or the author of the port decides not to follow the Aura guidelines. Of course, unofficial ones can be done without problems, but in this case it will not depend on our support.
About that red line in the tab the Buttons section in DOC says:
For any of these selectors, adding the document identifier specifies that the appearance should be applied to buttons appearing in document tabs, such as meta.document.button.
Maybe this is the way to change that red color, can you take a look at this, please?
I noticed that you only used one variant which is Aura.dark, is it not possible to use the available variants as was done in the vscode port?
The other change requests I made are still valid. Thanks. 💜
| * Window styles | ||
| */ | ||
| meta.window { | ||
| background-color: #110F18; |
There was a problem hiding this comment.
In general, colors in the template folder should be tokens (color accents), we should not put the hex values manually.
Take a look at aura tokenize command line helper to convert the hex values used by Aura to the right color tokens.
| @@ -0,0 +1,16828 @@ | |||
| { | |||
| "name": "aura-theme", | |||
There was a problem hiding this comment.
As it comes from npm and not yarn, remove this file please
|
Hi @DanKlaver15, are you still working on this PR? |
|
@daltonmenezes I’m sorry for the delay in responding. I haven’t had a chance to work on it and it looks like I won’t in the near future with everything I have going on now. |
Description
This PR: added port for Nova text editor
Assets
Checklist