Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

PublicKey should derive Hash #183

Closed
inetic opened this issue Nov 30, 2021 · 3 comments
Closed

PublicKey should derive Hash #183

inetic opened this issue Nov 30, 2021 · 3 comments

Comments

@inetic
Copy link

inetic commented Nov 30, 2021

Re-opening the issue #120 as it hasn't been solved yet.

The original author @dvc94ch seems to open and close issues because it fits his workflow.

The original text:

@dvc94ch wrote

Unless there's a cryptographic reason why it should not derive Hash, it would be a good idea.

@burdges wrote

It should define Hash with .0.as_bytes() not #[derive(Hash)] since the serialized form already exists, and because points in protective coordinates require normalization. Aside from the obvious reasons: Projective Coordinates Leak

There is currently a PR for this #176. Likely motivated by @burdges' comment here. The CI on that PR is currently failing, but it doesn't seem like the failure is caused by the PR changes.

Could someone please re-run the CI?

@dvc94ch
Copy link

dvc94ch commented Nov 30, 2021

looks like I may have closed it accidentally

@mimoo
Copy link

mimoo commented Jun 12, 2022

wondering about this as well

@rozbb
Copy link
Contributor

rozbb commented Jan 20, 2023

Resolved in #265

@rozbb rozbb closed this as completed Jan 20, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants