Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feature request: tag prop on Theme component #161

Closed
justinmetros opened this issue Jul 9, 2022 · 1 comment · May be fixed by #162
Closed

feature request: tag prop on Theme component #161

justinmetros opened this issue Jul 9, 2022 · 1 comment · May be fixed by #162

Comments

@justinmetros
Copy link

justinmetros commented Jul 9, 2022 •
edited
Loading

Feature Request:

  • allow for tag prop ( or similar ) on Theme component so it can be rendered as an element other than div

Use Case:

<Theme tag="body" dataTheme="dark">
  <main>{children}</main>
</Theme>

Output:

<body data-theme="dark">
  <main>
    <div>Hello World</div>
  </main>
</body>

Will try to open a PR if space allows and this interests the team, but floating this idea up in the meantime.

Thanks for all the work on this, so awesome!
@benjitrosch
Copy link
Collaborator

Hey @justinmetros,

Great idea! If you want to open a PR that would be great, otherwise I can take a look at this during the week and try to open a PR.

christianblandford added a commit that referenced this issue Jul 11, 2022
@christianblandford
feat: added "as" prop for polymorphic theme component #161
4d1c676
@christianblandford christianblandford mentioned this issue Jul 11, 2022
Draft
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

feat: polymoprphic theme component daisyui/react-daisyui
2 participants
@justinmetros @benjitrosch