Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade and add some opinionated stuff #32

Open
wants to merge 4 commits into
base: master
Choose a base branch
from

Conversation

alexppg
Copy link

@alexppg alexppg commented Feb 1, 2024

Hello!
First of all, thanks for your work, this project is awesome!
I've upgraded all the dependencies because I just begun to use it.
I also made a couple of changes that could be considered opinionated, so if you don't want those, I'll revert them, no problem.
One is build statically. The other is use distroless for docker container, which is supposed to be more secure.
Anyway, let me see what you think and let's go from them
Thanks again!

@@ -1,15 +1,25 @@
FROM debian:buster-slim AS build
FROM golang:1.21 as builder
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you so much for the improvements to the Docker files!

I agree with the use of distroless images, but I think it would be less problematic and more beneficial to download binaries generated by github actions rather than have users build the executables themselves, which would speed up the image generation. What do you think?

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sure, I agree, I'll change ASAP.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants