Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[dagster-sigma] Update custom translator example in Sigma docs #26037

Merged
merged 3 commits into from
Nov 25, 2024

Conversation

maximearmstrong
Copy link
Contributor

@maximearmstrong maximearmstrong commented Nov 20, 2024

Summary & Motivation

Like #26029 but for Sigma

@maximearmstrong maximearmstrong force-pushed the maxime/deprecate-get-asset-key-sigma-translator branch from e04b5fe to 7fefd3a Compare November 20, 2024 17:57
@maximearmstrong maximearmstrong force-pushed the maxime/update-sigma-docs-asset-key-translator branch from 27db01e to 03593cb Compare November 20, 2024 17:57
@maximearmstrong maximearmstrong force-pushed the maxime/deprecate-get-asset-key-sigma-translator branch from 7fefd3a to 4c971fe Compare November 20, 2024 20:32
@maximearmstrong maximearmstrong force-pushed the maxime/update-sigma-docs-asset-key-translator branch from 03593cb to 717e527 Compare November 20, 2024 20:32
@maximearmstrong maximearmstrong force-pushed the maxime/deprecate-get-asset-key-sigma-translator branch from 4c971fe to c982afd Compare November 25, 2024 19:09
@maximearmstrong maximearmstrong force-pushed the maxime/update-sigma-docs-asset-key-translator branch from 717e527 to 5e3a5c8 Compare November 25, 2024 19:09
@maximearmstrong maximearmstrong marked this pull request as ready for review November 25, 2024 19:28
@maximearmstrong maximearmstrong self-assigned this Nov 25, 2024
Copy link
Contributor

@dpeng817 dpeng817 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nice

@maximearmstrong maximearmstrong force-pushed the maxime/deprecate-get-asset-key-sigma-translator branch from c982afd to 0c84803 Compare November 25, 2024 21:02
@maximearmstrong maximearmstrong force-pushed the maxime/update-sigma-docs-asset-key-translator branch from 5e3a5c8 to ead843f Compare November 25, 2024 21:02
Base automatically changed from maxime/deprecate-get-asset-key-sigma-translator to master November 25, 2024 21:14
@maximearmstrong maximearmstrong force-pushed the maxime/update-sigma-docs-asset-key-translator branch from ead843f to 6414bbf Compare November 25, 2024 21:15
@maximearmstrong maximearmstrong merged commit 8048220 into master Nov 25, 2024
2 checks passed
@maximearmstrong maximearmstrong deleted the maxime/update-sigma-docs-asset-key-translator branch November 25, 2024 21:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants