Replies: 4 comments 4 replies
-
I think this is a good idea. |
Beta Was this translation helpful? Give feedback.
0 replies
-
agreed. is there a good way to warn when someone uses a top-level import as opposed to dotting into something?
Sent via Superhuman ( https://sprh.mn/[email protected] )
…On Wed, Oct 21, 2020 at 2:58 PM, Sandy Ryza < ***@***.*** > wrote:
I think this is a good idea.
—
You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub (
#3132 (comment)
) , or unsubscribe (
https://github.com/notifications/unsubscribe-auth/AG3IK6K5G62PV4DY2HSNWETSL5KPHANCNFSM4S2KR62A
).
|
Beta Was this translation helpful? Give feedback.
2 replies
-
yeah maybe we can just put a blanket warning in the constructor warning that it will no longer be a top level import and be clear about how to disable.
Sent via Superhuman ( https://sprh.mn/[email protected] )
…On Wed, Oct 21, 2020 at 5:04 PM, mgasner < ***@***.*** > wrote:
at a minimum i think we would need to edit sys.meta_path or equivalent in
the top level __init__. py ( http://__init__.py/ ) before importing
anything ourselves... very ugly and potentially dangerous
—
You are receiving this because you commented.
Reply to this email directly, view it on GitHub (
#3132 (reply in thread)
) , or unsubscribe (
https://github.com/notifications/unsubscribe-auth/AG3IK6PZO2BIELYVVG7KHSDSL5ZHFANCNFSM4S2KR62A
).
|
Beta Was this translation helpful? Give feedback.
2 replies
-
Hm, is the idea that we would also commit to maintain the dotted import? Or that this would become an internal API subject to change. |
Beta Was this translation helpful? Give feedback.
0 replies
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
-
The idea behind this API is that it smooths onboarding, but I think it's arguably more complicated to have it -- the front-end of the learning curve is very steep & adding any more concepts at the start isn't helping us.
Beta Was this translation helpful? Give feedback.
All reactions