Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding a devcontainer.json and a button for easy codespacing #1

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

tacastillo
Copy link

@tacastillo tacastillo commented Feb 22, 2023

Why

Because it'll allow anyone with a GitHub account to have Dagster running and editable in roughly a minute.

Next Steps

If they have the dev container extension for VS Code/Jetbrains, it'll work OOB and ask the user if they want to open up the project in a container locally.

To get the snappiness of Codespaces though, we'd need to set up a pre-build on GitHub. It makes a pretty lean image and GitHub will automatically use it when turning on a Codespace.

I don't have admin permissions on this repo, so I can't set it myself. If someone is too lazy to figure out how to add me but also is energetic enough to try it themselves:

  1. Head to https://github.com/dagster-io/biweekly-demo/settings/codespaces
  2. Click the green Set up prebuild button
  3. Have it set to run on every configuration change. It's technically not greedy enough, but with any changes we make, we can kick off a manual rebuild. (see pic below)
    image

Hit save and it'll take about 5 minutes to get built. To monitor this, peep the GitHub Actions tab. After that, click on the Open in GitHub Codespaces button in the README, click Create Codespace, give it a minute to spin up, and run dagster dev once it's warmed up.

Wrinkle: idk how this all plays in with the Dagster GH org. I'm currently using this pattern on a repo on my GitHub account, so unsure how GH is gonna treat the GHA minutes or the storage for the image on this org.

@github-actions
Copy link

github-actions bot commented Feb 22, 2023

Your pull request is automatically being deployed to Dagster Cloud.

Location Status Link Updated
population_analysis Deploy failed Feb 22, 2023 at 08:02 PM (UTC)

Copy link
Contributor

@yuhan yuhan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

i don't have admin perm either but will ask

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants