Adding a devcontainer.json and a button for easy codespacing #1
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why
Because it'll allow anyone with a GitHub account to have Dagster running and editable in roughly a minute.
Next Steps
If they have the dev container extension for VS Code/Jetbrains, it'll work OOB and ask the user if they want to open up the project in a container locally.
To get the snappiness of Codespaces though, we'd need to set up a pre-build on GitHub. It makes a pretty lean image and GitHub will automatically use it when turning on a Codespace.
I don't have admin permissions on this repo, so I can't set it myself. If someone is too lazy to figure out how to add me but also is energetic enough to try it themselves:
Set up prebuild button
Hit save and it'll take about 5 minutes to get built. To monitor this, peep the GitHub Actions tab. After that, click on the
Open in GitHub Codespaces
button in theREADME
, clickCreate Codespace
, give it a minute to spin up, and rundagster dev
once it's warmed up.Wrinkle: idk how this all plays in with the Dagster GH org. I'm currently using this pattern on a repo on my GitHub account, so unsure how GH is gonna treat the GHA minutes or the storage for the image on this org.