Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ISO weekday number (%u) #31

Closed
adius opened this issue Jul 9, 2017 · 4 comments
Closed

ISO weekday number (%u) #31

adius opened this issue Jul 9, 2017 · 4 comments

Comments

@adius
Copy link

adius commented Jul 9, 2017

ISO weekdays are Monday based and numbered 1-7, but d3 only provides %w, which is Sunday based and numbered 0-6.

E.g. momentjs uses E for ISO weekday.
@mbostock mbostock changed the title ISO weekday directive for specifier string ISO weekday number (Monday-based, 1-7) Jul 9, 2017
@mbostock
Copy link
Member

mbostock commented Jul 9, 2017

Reference: https://en.wikipedia.org/wiki/ISO_week_date

@mbostock
Copy link
Member

mbostock commented Jul 9, 2017

Related #8; having ISO 8601 weekday number is not especially useful without also having support for ISO 8601 week numbers. (%U and %W are not ISO 8601 week numbers.)

@mbostock mbostock changed the title ISO weekday number (Monday-based, 1-7) ISO weekday number (%u, Monday-based, 1-7) Jul 9, 2017
@mbostock
Copy link
Member

mbostock commented Jul 9, 2017

For consistency with strftime this should use the %u directive.

@mbostock mbostock changed the title ISO weekday number (%u, Monday-based, 1-7) ISO weekday number (%u) Jul 9, 2017
@BrianMitchL BrianMitchL mentioned this issue Oct 2, 2017
Merged
@mbostock
Copy link
Member

mbostock commented Oct 9, 2017

Fixed in #36.

@mbostock mbostock closed this as completed Oct 9, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@mbostock @adius