Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Make hierarchies immutable? #148

Closed
mbostock opened this issue Aug 25, 2019 · 2 comments
Closed

Make hierarchies immutable? #148

mbostock opened this issue Aug 25, 2019 · 2 comments

Comments

@mbostock
Copy link
Member

Currently the layouts mutate the passed-in hierarchies in-place, but it’d be cleaner if they didn’t. For instance, you could pass the same root node to multiple hierarchy layouts and they would co-exist happily.

You can workaround this now using node.copy, but I think we should consider how we might do this automatically.
@curran
Copy link

curran commented Aug 26, 2019

Immutability FTW!

@mbostock mbostock mentioned this issue Nov 17, 2019
Open
@mbostock
Copy link
Member Author

mbostock commented May 5, 2020

Duplicate of #62.

@mbostock mbostock closed this as completed May 5, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@curran @mbostock