Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

clipping bug #39

Closed
Tracked by #61
Fil opened this issue May 28, 2020 · 0 comments · Fixed by #60
Closed
Tracked by #61

clipping bug #39

Fil opened this issue May 28, 2020 · 0 comments · Fixed by #60
Assignees
@Fil

Comments

@Fil
Copy link
Member

Fil commented May 28, 2020 •
edited
Loading

In https://observablehq.com/@fil/oronce-fines-triangle-projection the graticule was properly clipped until [email protected], but it failed with release 1.8.0.
I think the offending commit is eb1e663 (#160).

Test @ https://observablehq.com/@fil/clipping-bug-39

This is also the reason why #60 (rhombic) had a small rotation. Same bug appears in https://observablehq.com/d/8085f693f9972f0e (#9)
@Fil Fil self-assigned this May 28, 2020
This was referenced Jun 9, 2024
Merged
Merged
Fil added a commit that referenced this issue Jun 10, 2024
@Fil
fix untractable alignments (e.g. in the rhombic projection)
5c41964 
closes #39
Fil added a commit that referenced this issue Jun 10, 2024
@Fil
fix untractable alignments (e.g. in the rhombic projection)
c292472 
closes #39
Fil added a commit that referenced this issue Jun 10, 2024
@Fil
fix untractable alignments (e.g. in the rhombic projection)
53851be 
closes #39
@Fil Fil closed this as completed in #60 Jun 10, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@Fil Fil

Labels
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

rhombic & deltoidal d3/d3-geo-polygon
1 participant
@Fil