Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Support d3.drag in testing environments #89

Open
penx opened this issue Jan 27, 2023 · 0 comments · May be fixed by #90
Open

Support d3.drag in testing environments #89

penx opened this issue Jan 27, 2023 · 0 comments · May be fixed by #90

Comments

@penx
Copy link

penx commented Jan 27, 2023

As per the report in #79 which was closed without a fix.

If using d3-drag in a non browser environment, such as jest + testing-library, an error will be thrown:

    Error: Uncaught [TypeError: Cannot read property 'document' of null]

This comes from

d3-drag/src/drag.js

Lines 50 to 63 in c6a7e46

function mousedowned(event, d) {
if (touchending || !filter.call(this, event, d)) return;
var gesture = beforestart(this, container.call(this, event, d), event, d, "mouse");
if (!gesture) return;
select(event.view)
.on("mousemove.drag", mousemoved, nonpassivecapture)
.on("mouseup.drag", mouseupped, nonpassivecapture);
nodrag(event.view);
nopropagation(event);
mousemoving = false;
mousedownx = event.clientX;
mousedowny = event.clientY;
gesture("start", event);
}

d3-drag/src/nodrag.js

Lines 4 to 5 in c6a7e46

export default function(view) {
var root = view.document.documentElement,

Because view is null.

Downstream issues:

I think nodrag should return early if view is null:

export default function(view) {
  if(!view) {
    return;
  }
  var root = view.document.documentElement,
      selection = select(view).on("dragstart.drag", noevent, nonpassivecapture);
  if ("onselectstart" in root) {
    selection.on("selectstart.drag", noevent, nonpassivecapture);
  } else {
    root.__noselect = root.style.MozUserSelect;
    root.style.MozUserSelect = "none";
  }
}

...at least, this works for my use case. I'll raise a PR.
penx added a commit to penx/d3-drag that referenced this issue Jan 27, 2023
@penx
Support d3.drag in testing environenments
2fa69f2 
Return early from nodrag if no view is passed.

Fixes d3#89
@penx penx linked a pull request Jan 27, 2023 that will close this issue
Open
penx added a commit to penx/d3-drag that referenced this issue Jan 27, 2023
@penx
Support d3.drag in testing environments
bfe249f 
Return early from nodrag if no view is passed.

Fixes d3#89
penx added a commit to penx/d3-drag that referenced this issue Jan 27, 2023
@penx
Support d3.drag in testing environments
1a87936 
Return early from nodrag if no view is passed.

Fixes d3#89
This was referenced Jan 27, 2023
Open
Closed
@freben freben mentioned this issue Oct 5, 2023
Merged
1 task
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Support d3.drag in testing environments penx/d3-drag
1 participant
@penx