-
Notifications
You must be signed in to change notification settings - Fork 92
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Jzazbz color space #51
Comments
Yes, that’s a good idea. There’s a nice implementation here by Jacob Rus: |
I could make a PR to add support for Jzazbz. One thing that nags me is that the color space operates CIE XYZ absolute values, and I'm not sure how to scale relative XYZ values to meet the authors' intentions and make the best use of Jzazbz (or whether the decision alters the qualities of this color space in significant ways). @jrus uses 200 cd/m2 in his notebook. |
@danburzo are you still working on this? If not, would you mind if I attempted a PR? |
@DCtheTall not at all! I have not had the chance to put together the PR, so I'm happy to pass the baton. I have an initial implementation here, if it helps in any way. |
I haven't forgotten about this, just been busy at work. I plan on getting to this still 😅 |
Took a look at this today and I think the best approach is to start by separating the XYZ color space in If that sounds like the right idea, I have a draft PR up now with this issue tagged. If there's a reason not to do this (like the XYZ space in |
I think extracting XYZ D50 as its own color space is a useful addition to the API. However, one thing I'm not sure about, is which XYZ space should
In the current implementation of d3.lab, While XYZ D50 is useful for Lab/LCh and the ProPhoto RGB color space. On the other hand, XYZ D65 is useful for Jzazbz or DIN99. |
@danburzo thanks for the clarification between XYZ D65 and D50. It seems to me that since D65 is actually used by multiple color space conversion methods, it makes sense from a software design perspective to refactor it out to make it reuseable. As for whether to make XYZ D50 its own module, I'll defer that to the others on this thread. I think it probably does make sense to have it be its own module as well. |
@danburzo after thinking on this some, I think it makes sense to have both XYZ spaces as their own module. As for the name, I was thinking there should be |
Some new color space: https://www.osapublishing.org/oe/fulltext.cfm?uri=oe-25-13-15131&id=368272
Here python implementation https://github.com/nschloe/colorio
Maybe d3 can support it?
The text was updated successfully, but these errors were encountered: