Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Define ideal compartment and metadata table relationships for joins to avoid returning NA results #201

Open
d33bs opened this issue Apr 26, 2024 · 0 comments
Labels
enhancement New feature or request

Comments

@d33bs
Copy link
Member

d33bs commented Apr 26, 2024

@jenna-tomkinson brought up a scenario in which cytoplasm and cells table data may exist in a dataset where nuclei may be missing. As-is, this could produce rows of CytoTable output which include cytoplasm and cells feature data but NA's for nuclei data. This happens because the cytoplasm table is used as a basis for the preset joins (there's no constraint that would prevent someone from specifying otherwise). We could use the nuclei table as the basis for preset joins which would remove this possibility. Chatting about this together with @MikeLippincott it came up that retaining the NA rows could be important information for a data scientist to see as part of their efforts.

Opening this issue up to help document the discussion and provide an area for further thoughts to be documented.

@d33bs d33bs added the enhancement New feature or request label Apr 26, 2024
@d33bs d33bs changed the title Define ideal compartment and metadata table relationships to avoid returning NA results Define ideal compartment and metadata table relationships for joins to avoid returning NA results Apr 26, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

1 participant