imapd: track characters used in IMAP tags #5055
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rsto
previously approved these changes
Sep 25, 2024
ksmurchison
previously approved these changes
Sep 25, 2024
|
We think we don't want to actually merge this, just include it in our builds until we've got the data we're interested in, then drop it. |
|
@elliefm I removed the |
elliefm
force-pushed
the
v311/client-imaptags-behaviour
branch
from
5e9e139 to
c7e3929
Compare
|
@rsto I've fixed the conflicts, so we could re-tag it now. But actually, I think I'll take the opportunity to change the data it collects based on what we saw from the first run. So let's not re-tag it just yet, wait till I've got it ready for the next lot of stats. |
(tags otherwise containing dots are still unusual)
elliefm
force-pushed
the
v311/client-imaptags-behaviour
branch
from
5c9fab8 to
2ba2745
Compare
|
@ksmurchison @rsto I've updated this to log unusual tags at LOG_INFO rather than LOG_DEBUG, and improve the tracking and reporting based on shortcomings I noticed in the original stats. The last 3 commits are the new ones. |
ksmurchison
approved these changes
Nov 13, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This extends the existing IMAP client behaviour tracking to record categories of characters used in tags
We don't have existing tests for the client behaviour logging, except for a couple of cursory checks in Simple and ID. I might feel more comfortable with some tests that verify the character class mappings detect as expected, but it'd be a whole new test suite, is it worth the effort? I dunno.