fix: Standardize filter params for class
#10
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mike-plummer
requested review from
chrisbreiding,
tbiethman,
mabela416 and
astone123
chrisbreiding
approved these changes
Aug 5, 2024
|
🎉 This issue has been resolved in version 2.0.1 🎉 The release is available on: Your semantic-release bot 📦🚀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Supporting CP-3167
Standardize the parameters passed into the
filterfunction when considering theclassattribute so it's more clear that we're filtering a portion of the attribute value (a single class token), not the whole thing.This library was already splitting the class attribute and filtering individually so a subset of classes could be included/excluded, but was passing an unexpected
typeparam which caused the filter function in uicov to not always fire as expected.