Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

move lib.normalize calls into install #64

Open
cyberrumor opened this issue Nov 15, 2024 · 0 comments
Open

move lib.normalize calls into install #64

cyberrumor opened this issue Nov 15, 2024 · 0 comments

Comments

@cyberrumor
Copy link
Owner

cyberrumor commented Nov 15, 2024

lib.normalize is really slow and called very often. If mods were doctored during the install step, they wouldn't have to have their paths corrected during staging. This would provide a sizable speedup for modlists with a large number of loose files.

Existing mods will have to be handled in some way or another so users don't have to reinstall their modlists when lib.normalize is removed from staging.

In my very humble modlist, lib.normalize is called upwards of 44,000 times just from launching ammo then running commit.

The purpose of lib.normalize is to prevent the same folders but with different casing from being created inside of the game directory.

E.g.

my_mod/Data/skse/PLUGINS/some_plugin.dll
my_other_mod/data/SKSE/Plugins/some_other_plugin.dll
my_third_mod/DATA/Skse/plugins/some_third_plugin.dll

should only create one folder path with all three files under it:

my_game/Data/SKSE/Plugins/*
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant