Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fomod local sub-data directories do not have normalized capitalization #15

Open
cyberrumor opened this issue Apr 9, 2023 · 3 comments
Labels
bug Something isn't working

Comments

@cyberrumor
Copy link
Owner

For example, DynDOLOD resources is still installing with dyndolod_resources/Data/meshes and dyndolod_resources/Data/Meshes. This was thought to have been fixed with commit 281d60d, but it wasn't.

@cyberrumor cyberrumor added the bug Something isn't working label Apr 11, 2023
@cyberrumor
Copy link
Owner Author

I think the reason I was actually having problems with DynDOLOD resources was because of the duplicate filename bug (fixed). It should be possible to re-examine this ticket now. Hopefully it just involves calling normalize() on the filenames being copied from the folders that ModuleConfig.xml points at to mods/<mod_name>/Data

@cyberrumor
Copy link
Owner Author

Actually it looks like we're already normalizing them? Might just need to add a test for this and remove the TODO comments.

@cyberrumor
Copy link
Owner Author

Looking into filesystem-level "case folding" to handle this type of thing automatically both in the game folder and in mod folders.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

1 participant