Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Bug] Models Disappear without Warning if Manifest is Invalid #91

Open
alexandermichels opened this issue Mar 29, 2023 · 1 comment
Open

Comments

@alexandermichels
Copy link
Member

Problem: Extremely minor issues in mainfest.jsons like a misplaced comma cause the Core to stop presenting the model as an option without notifying anyone as to why. It requires an admin checking the logs on the Core to see the problem. This might be a difficult problem to tackle because we don't own the repos for the models, model developers do.

I think the best solution is to write a simple "validate JSON" Github workflow and ask model developers to use it on their repos so they know if they push an invalid JSON. However, we are open to any suggestions.

@mitkotak
Copy link
Collaborator

I think the best solution is to write a simple "validate JSON" Github workflow and ask model developers to use it on their repos so they know if they push an invalid JSON. However, we are open to any suggestions.

Not sure whether its practical but I am thinking along the lines of using this kind of Github Action and maybe somehow automatically updating the schema.json here from core.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants