Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[feature request]Allow model developer to control launching method for pre_processing_stage, execution_stage and post_processing_stage #22

Open
zhiyuli opened this issue Nov 5, 2021 · 0 comments
Labels
enhancement New feature or request

Comments

@zhiyuli
Copy link
Contributor

zhiyuli commented Nov 5, 2021

Currently pre_processing_stage and post_processing_stage are launched in single process/threaded mode, execution_stage is ran in mpi mode through "srun --unbuffered --mpi=pmi2".

In some cases model developer would require more flexibility to control how each step is launched.
We could allow developer to specify a string/command in the manifest.json for each step and insert the string/command between and .

This will be a optional switch, and only override old sbatch file if they are present

for example, this following manifest will allow all the 3 steps to be launched by MPI

{
"name": "MPI Hello World",
"container": "mpich",
"pre_processing_stage": "python setup.py",

"pre_processing_stage_launching_command": "xxxxxxxxxx1",

"execution_stage": "python main.py",

"execution_stage_launching_command": "xxxxxxxxxxxxxxx2",

"post_processing_stage": "python cleanup.py",

"post_processing_stage_launching_command": "xxxxxxxxx3",

"slurm_ceiling": {
    "walltime": "2:00"
}

}

@zhiyuli zhiyuli changed the title Allow model developer to control launching method for pre_processing_stage, execution_stage and post_processing_stage [feature request]Allow model developer to control launching method for pre_processing_stage, execution_stage and post_processing_stage Nov 5, 2021
@alexandermichels alexandermichels added this to the Future milestone Jan 24, 2023
@alexandermichels alexandermichels removed this from the Future milestone Feb 27, 2024
@alexandermichels alexandermichels added the enhancement New feature or request label Apr 2, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants