Extract Pitch Detection into stand-alone module (+ enhance GUI) #8
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Great job, @markmarijnissen! I was just about to do this myself when I saw that someone had already done this! 👍 |
|
It would be great for this to be merged. 👍 😄 |
TypeError: Failed to execute 'webkitGetUserMedia' on 'Navigator': The value provided is neither an array, nor does it have indexed properties.
Tried changing optional `[]` to optional `{}` and didn't work, so deleted line instead
Firefox seems to continue to work
Merged
fix syntax err in docs example
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi Chris,
I've extracted the logic into a standalone module. If you are familiar with NPM, you should be able to register this module using
npm register. Then we can allnpm installthe module and use it with webpack and browserify!I'm willing to publish to NPM, if you want.
Also, I've enhanced the GUI. The wave display didn't help me much in understanding what was going on. Check it out at http://lab.madebymark.nl/pitch-detector/example/
cheers
Mark