Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

an issue about the results of paper model. #7

Open
Lininggggggg opened this issue Nov 3, 2020 · 3 comments
Open

an issue about the results of paper model. #7

Lininggggggg opened this issue Nov 3, 2020 · 3 comments

Comments

@Lininggggggg
Copy link

Lininggggggg commented Nov 3, 2020

hello, i have an issue is about the compared model of FSRCNN(origin), and your model of FSRCNN training by PISR.
the origin model of fsrcnn is trained without div2k, but your model has.
so, maybe your method is no good as your paper shows, because if the origin model of fsrcnn is trained with the same trainset like yours, it will better than before, right?
image
if i am wrong, could you tell me why, please?
thanks you very much!

@Lininggggggg
Copy link
Author

emm,ok, i am sorry. i am wrong.
you had deal with this problem in the paper.
thanks you for your excellent work!

@Lininggggggg
Copy link
Author

sorry, i still have another problem.
the multiadds of fsrcnn is false, and the reason maybe is the package you used to count flops is error.(the deconv stride is the same as upscale, so the correct flops should be 0.738259GMac.)
you can check it by the origin paper or use the package like "from thop import profile".
image

@Lininggggggg Lininggggggg reopened this Nov 3, 2020
@Lininggggggg
Copy link
Author

i hope you can reply me.
thank you very much!!!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant