Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Sift based local feature extraction is not working bcause of update in pycolmap. #352

Closed
prasad-pr-20 opened this issue Jan 18, 2024 · 2 comments

Comments

@prasad-pr-20
Copy link

The local feature extractor SIFT based DOG extractor class model in hloc/extractors/dog.py seems to be now broken becuase of the update in the pycolmap.
With the latest pycolmap 0.5.0, pycolmap.sift.extract returns only two parameters while three are expected in the current code.
keypoints, scores, descriptors = self.sift.extract(image_np). Upon execution, we get the below error:

ValueError: not enough values to unpack (expected 3, got 2)

Upon performing a quick RCA, we observed that the current pycolmap i.e., 0.5.0 version, returns just keypoints and descriptors and omits scores, which is the reason for the breakdown.

Any suggestion/fix on how to obtain the score value or fix the existing solution is greatly appreciated.
Thanks in advance.

@prasad-pr-20 prasad-pr-20 changed the title Sift based local feature extraction is not working ebcause of update in pycolmap. Sift based local feature extraction is not working bcause of update in pycolmap. Jan 18, 2024
@sarlinpe
Copy link
Member

Will be fixed in #353

@sarlinpe
Copy link
Member

#353 has been merged.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants