Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Fixes issue with legacy renderer bridge #469

Merged
merged 3 commits into from
Nov 29, 2024

Conversation

BernardGatt
Copy link
Contributor

@BernardGatt BernardGatt commented Nov 28, 2024

Reintroduces bridge function to pass messages between SDK and Renderer

Fixes issue: https://linear.app/customerio/issue/MBL-721/mobile-in-app-crashes-after-updating-from-version-3x-to-44-of-android

Copy link

github-actions bot commented Nov 28, 2024

Sample app builds 📱

Below you will find the list of the latest versions of the sample apps. It's recommended to always download the latest builds of the sample apps to accurately test the pull request.


@BernardGatt BernardGatt changed the title Reintroduces bridge function to pass messages between SDK and Renderer fix: Fixes issue with legacy renderer bridge Nov 28, 2024
Copy link

codecov bot commented Nov 28, 2024

Codecov Report

Attention: Patch coverage is 0% with 2 lines in your changes missing coverage. Please review.

Project coverage is 51.76%. Comparing base (8b30804) to head (bf0b258).
Report is 23 commits behind head on main.

Files with missing lines Patch % Lines
...inginapp/gist/presentation/engine/EngineWebView.kt 0.00% 2 Missing ⚠️
Additional details and impacted files
@@             Coverage Diff              @@
##               main     #469      +/-   ##
============================================
+ Coverage     41.98%   51.76%   +9.77%     
- Complexity      259      290      +31     
============================================
  Files            99       96       -3     
  Lines          2320     2585     +265     
  Branches        344      355      +11     
============================================
+ Hits            974     1338     +364     
+ Misses         1247     1139     -108     
- Partials         99      108       +9     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link

  • java_layout: bernard/MBL-721-bridge-fix (1732797596)

Copy link

Build available to test
Version: bernard-MBL-721-bridge-fix-SNAPSHOT
Repository: https://s01.oss.sonatype.org/content/repositories/snapshots/

Copy link

github-actions bot commented Nov 28, 2024

📏 SDK Binary Size Comparison Report

No changes detected in SDK binary size ✅

Copy link

  • kotlin_compose: bernard/MBL-721-bridge-fix (1732797613)

…resentation/engine/EngineWebView.kt

Co-authored-by: Shahroz Khan <[email protected]>
Copy link

  • java_layout: Build failed. See CI job logs to determine the issue and try re-building.

Copy link

  • kotlin_compose: Build failed. See CI job logs to determine the issue and try re-building.

Copy link

  • java_layout: bernard/MBL-721-bridge-fix (1732867199)

Copy link

  • kotlin_compose: bernard/MBL-721-bridge-fix (1732867197)

@BernardGatt BernardGatt merged commit ecd89dd into main Nov 29, 2024
33 of 35 checks passed
@BernardGatt BernardGatt deleted the bernard/MBL-721-bridge-fix branch November 29, 2024 08:04
@BernardGatt BernardGatt restored the bernard/MBL-721-bridge-fix branch November 29, 2024 08:04
@BernardGatt BernardGatt deleted the bernard/MBL-721-bridge-fix branch November 29, 2024 08:04
github-actions bot pushed a commit that referenced this pull request Nov 29, 2024
## [4.4.1](4.4.0...4.4.1) (2024-11-29)

### Bug Fixes

* Fixes issue with legacy renderer bridge ([#469](#469)) ([ecd89dd](ecd89dd))
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants