Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Python: Make tests pass against shared test data #18

Open
2 tasks
aslakhellesoy opened this issue Oct 18, 2021 · 2 comments
Open
2 tasks

Python: Make tests pass against shared test data #18

aslakhellesoy opened this issue Oct 18, 2021 · 2 comments
Assignees
@jenisys

Comments

@aslakhellesoy
Copy link
Contributor

In #9 we introduced shared test data. The Python implementation should be updated to:

  • Run all tests in testdata/*.yml
  • Update the implementations to make those tests pass
@aslakhellesoy aslakhellesoy mentioned this issue Oct 18, 2021
Merged
6 tasks
@jenisys
Copy link
Contributor

jenisys commented Jun 2, 2023

Pull #95 contains an implementation to use the test data for Python.

  • Run all tests in testdata/*.yml
  • Update the implementations to make those tests pass

HINTS:

  • The backslash-escaping mechanism is not implemented yet for Python
  • Therefore, tests that use the backslash-escaping mechanism are currently skipped

jenisys added a commit that referenced this issue Jun 2, 2023
@jenisys
UPDATED: CHANGELOG for pull #95
255cf34 
* Fixes: #94
* Implements: #18
jenisys added a commit that referenced this issue Jul 2, 2023
@jenisys
Fix double-parenthesis in string representation (#95)
db49df7 
* FIXED #94 Not.to_string() conversion leads to double-parenthesis

IMPLEMENTED FIX FOR:

* [x] java
* [x] javascript
* [x] python

* FIX CI-BUILD: Missing dependency PyYAML

* Python 2.7 related issues (pytest, pathlib related)
* FIX: tox to test Python 2.7 usecase locally

UPDATE: Dependencies

* setup.py
* py.requirements/*.txt -- testing and development related

* FIX CI BUILD: prettier formatting issue

* FIXES #94 for Go programming language

* notExpr.ToString()
* ADDED: Evaluatable.isBinaryOperator() (used by: notExpr)
  REASON: Was faster than providing an instance-of implementation

* FIXES #94 for Ruby programming language

    * Not.to_s()  -- to_string conversion

* FIXES #94 for Perl programming language

* go: Provide IsBinaryOperator function

* Remove IsBinaryOperator() method in Evaluatable interface
* Provide IsBinaryOperator() function instead
  that encapsulates the is-instance-of And/Or expression.

* perl: Use isa operator instead of isBinaryOperator method

* Remove Node::isBinaryOperator() method and implementations

* go: Use "isBinaryOperator" (naming style change)

* Use "isBinaryOperator()" (was: "IsBinaryOperator")
  to comply w/ Go naming conventions and avoid to expose
  the this helper function to the public API of this package.

* UPDATED: CHANGELOG for pull #95

* Fixes: #94
* Implements: #18

* CI workflow: test-python -- Remove Python 2.7

* REASON: Github Actions support for Python 2.7 was removed (in 2023-06)
* Try to use pypy-2.7 instead (until Python 2.7 support is dropped)

* CI workflow: test-python -- Remove Python 2.7

* REASON: Github Actions support for Python 2.7 was removed (in 2023-06)
* Try to use pypy-2.7 instead (until Python 2.7 support is dropped)
@luke-hill
Copy link
Contributor

@jenisys - Not sure if you're still around / maintaining and checking python. But 2/3 of the shared tests are now ran. Just the errors ones aren't running. This feels like this issue is close to being "close off-able"

cc/ @brasmusson

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@jenisys jenisys

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@aslakhellesoy @jenisys @luke-hill