-
-
Notifications
You must be signed in to change notification settings - Fork 67
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[PHP] Require PHP 8.2 in composer.json #229
base: main
Are you sure you want to change the base?
Conversation
Try updating PHP dev deps - that is:
try with a 4.x dep, and now the conflict
So I'd like a psalm that supports php-parser 5. |
@ciaranmcnulty do you think we have a prayer at upgrading this? |
@mpkorstanje To me, it seemed like psalm isn't yet ready, but perhaps we can make it ready, by creating a psalm that supports the new parser version? |
Thanks for looking into this. It looks like PHP 8.1 will still get updates so I think we can wait for Psalm to upgrade their parser. |
This PR is a follow-up to #228.
NEEDS to wait for Psalm to release a version that supports php-parser v5.
🤔 What's changed?
Make the dependency on a non-EOL'd PHP version manifest in composer.json.
⚡️ What's your motivation?
A good comment in #228.
🏷️ What kind of change is this?