Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

perl: Adding a new translation has a dependency on perl #33

Open
Tracked by #2
mpkorstanje opened this issue Nov 8, 2022 · 3 comments
Open
Tracked by #2

perl: Adding a new translation has a dependency on perl #33

mpkorstanje opened this issue Nov 8, 2022 · 3 comments

Comments

@mpkorstanje
Copy link
Contributor

mpkorstanje commented Nov 8, 2022

🤔 What's the problem you've observed?

When a contributor updates gherkin-languages.json they'll run make copy-gherkin-languages to copy this file and/or generate derived for each implementation. This process should be light weight only depend on a few tools such as jq, however for Perl, this process currently depends on Perl.

gherkin/perl/Makefile

Lines 32 to 37 in 1cc2ef0

copy-gherkin-languages: # lib/Gherkin/Generated/Languages.pm ## Copy gherkin-languages.json and/or generate derived files
echo "TODO: Depends on perl, this task should only depend on jq"
clean-gherkin-languages: ## Remove gherkin-languages.json and any derived files
# rm -f lib/Gherkin/Generated/Languages.pm
echo "TODO: Depends on perl, this task should only depend on jq"

✨ Do you have a proposal for making it better?

Consider using jq instead of perl to generate Languages.pm instead. For example see:

https://github.com/cucumber/gherkin/blob/1cc2ef0153603c5e51818b59ff6d632238491226/go/dialects_builtin.go.jq

@mpkorstanje
Copy link
Contributor Author

@ehuelsmann might be good to pick this up in combination with #32

@mpkorstanje mpkorstanje mentioned this issue Nov 8, 2022
71 tasks
@ehuelsmann
Copy link
Contributor

This problem would be solved by using the sames solution as the one i suggested in #32. I guess I could try to generate valid Perl from inside jq, but I wonder if that's worth the effort, or that we're really trying to solve the wrong problem here...

@mpkorstanje
Copy link
Contributor Author

Perhaps, let's try to work this out in #32.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants