Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use polyglot-release for releasing #137

Open
wants to merge 2 commits into
base: main
Choose a base branch
from
Open

Conversation

lsuski
Copy link
Contributor

@lsuski lsuski commented Aug 19, 2024

🤔 What's changed?

Apply changes to allow using polyglot-release script for releasing

⚡️ What's your motivation?

Align with other cucumber repositories releasing process

🏷️ What kind of change is this?

  • 📖 Documentation (improvements without changing code)
  • 🏦 Refactoring/debt/DX (improvement to code design, tooling, etc. without changing behaviour)

♻️ Anything particular you want feedback on?

Adjusting RELEASING.md to contain new releasing process

📋 Checklist:

  • I agree to respect and uphold the Cucumber Community Code of Conduct
  • I've changed the behaviour of the code
    • I have added/updated tests to cover my changes.
  • My change requires a change to the documentation.
    • I have updated the documentation accordingly.
  • Users should know about my change
    • I have added an entry to the "Unreleased" section of the CHANGELOG, linking to this pull request.

This text was originally generated from a template, then edited by hand. You can modify the template here.

@lsuski
Copy link
Contributor Author

lsuski commented Aug 19, 2024

Requires cucumber/polyglot-release#101

@mpkorstanje
Copy link
Contributor

You can also update the release guide to point to https://github.com/cucumber/.github/blob/main/RELEASING.md

@lsuski
Copy link
Contributor Author

lsuski commented Aug 20, 2024

@mpkorstanje Is this tool working on Windows? Unfortunately I'm working on Windows

@mpkorstanje
Copy link
Contributor

Unfortunately not. It is a shell script.

I also haven't used Windows for over a decade now. So I am not familiar with the state of the art around the Windows Subsystem for Unix or Dev containers. You can probably also get it to work in Cygwin. I reckon you might want to try to get it to work with one of those. If you run into troubles there I will be happy to help.

And if not, doing things manually is still an option, if a bit error prone.

Copy link
Contributor

@mpkorstanje mpkorstanje left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think we can merge this. Even if you can't use polyglot-release other people might.

Unless using a properties file for versions is not the preferred solution in general.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants