-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Syntax for links #122
Comments
I've made this issue so you can make any changes you want now |
according to naming protocols, shouldn't it be "activitysheet", not
"activity-sheets" in the sample syntax you provided?
…On Mon, Jul 1, 2024 at 12:54 PM Naomi Rosenkranz ***@***.***> wrote:
I've made this issue so you can make any changes you want now
—
Reply to this email directly, view it on GitHub
<#122 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AF75UYFWRX37KGJWXZQN7RDZKGCT7AVCNFSM6AAAAABKF6FVZGVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDEMBQGYZDIMBWGA>
.
You are receiving this because you were assigned.Message ID:
***@***.***>
|
sorry, never mind! I misspoke.
…On Mon, Jul 1, 2024 at 2:40 PM Pamela H. Smith ***@***.***> wrote:
according to naming protocols, shouldn't it be "activitysheet", not
"activity-sheets" in the sample syntax you provided?
On Mon, Jul 1, 2024 at 12:54 PM Naomi Rosenkranz ***@***.***>
wrote:
> I've made this issue so you can make any changes you want now
>
> —
> Reply to this email directly, view it on GitHub
> <#122 (comment)>,
> or unsubscribe
> <https://github.com/notifications/unsubscribe-auth/AF75UYFWRX37KGJWXZQN7RDZKGCT7AVCNFSM6AAAAABKF6FVZGVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDEMBQGYZDIMBWGA>
> .
> You are receiving this because you were assigned.Message ID:
> ***@***.***>
>
|
I think I've diagnosed the html internal links problem: |
For NJR/THC to check: a good page with lots of links that does not work presently with markdown syntax: https://teaching640.makingandknowing.org/resources/activity-sheets/activitysheet_jasper |
@ps2270 |
Links to other pages (i.e.,
|
In this doc: https://github.com/cu-mkp/research-teaching-companion/blob/main/content/resources/activity-sheets/activitysheet_varnishes.md |
And maybe with only file name (no path): |
Search regular expression: replace with: |
For the few files that have |
To remove any file references with |
@ps2270 found additional broken links that she corrected as she was going through but did not document in this issue. I want to document some of these to see if there are other similar issues here. So, we are reviewing some of her commits. One example is c6b7a87 where there is Another example is missing a leading slash as here: cdb7d03 Another: inclusion of Another is missing training slashes 029ff76 and 49261f5 missing trailing slashes and missing |
latest build to site (2024-07-31 at 1:30pm ET) returned no warnings or missing links files. This does not mean it doesn't have problems, but at least according to Hugo, it doesn't see any errors |
NEXT: in oxygen, search for the common problems as found by PHS (described two comments ago) to double check that there are no other ones |
It seems that |
PDFs:
XLSX: Non-pdfs:
none with |
Find any links with markdown syntax and no leading slash: |
Files fixed in commits dated today (2024-08-06): |
NEXT:
|
@njr2128 |
I'm a little confused. For pages that are in the same directory level AND are in the top-most directory of On the about.md page, to link to credits.md: |
@njr2128 |
Follow the instructions as outlined in our READ ME: https://github.com/cu-mkp/research-teaching-companion?tab=readme-ov-file#internal-links
[text for link](link)
[Stucco for Molding](/resources/activity-sheets/stucco-assignment)
-- and make sure the/
is there at the beginning of the file path![stucco assignment](/documents/activity-sheets/stucco_assignment_student-handout.pdf)
The text was updated successfully, but these errors were encountered: