-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Validation of Corsika config files #10
Comments
@Voutsi, about the magnetic field, note that it also depends on the height a.s.l., what height have you used? |
@jsitarek , 2199m. |
I'm not sure how it was done in the previous CTA production, but at least in MAGIC the (really old) values that we are using is not at the ground level, but at the height where the typical shower maximum happens, I do not remember which exactly value was used, but something of the order of 10 km. a.s.l.. The difference will not be large, but if we are already updating things, I would suggest to use a value at ~10 km |
Hi @Voutsi for most of the things you mention we should not make any change, right? As for the B-field date let's go for some round value. ARRANG sets the angle between geographic coordinates (the telescopes' ones) and "magnetic" (Corsika's) coordinates, so the angle must be the magnetic declination for whatever B-field date we choose. Mind the sign (check the earlier production settings) data storage tree: I agree with your proposal. |
Why do we use different branches for the different programs? Wouldn't it be much easier to just have them in different directories? Then the current complete configuration could be seen on the main branch. With the branches, I'd had to checkout two or three branches in parallel. |
The idea is to have independent versioning for the corsika and simtel, since we might run simtel several times on the same corsika files. |
moreover, when we decide on each configuration, it must be tagged (so only tags are used in production, not the branches, which are mutable) |
Yes, sure. But then you'd use tags to different branches that don't have a shared history (other maybe than the first commit?). Moreover, if you do related changes, they cannot be done in the same commit. What you propose here is a pretty strong deviation from how git is normally used (explicitly creating unrelated branches). And I don't really see why the two reasons you gave warrant that. |
Well, the main reason is: corsika simulates showers, sim_telarray simulates their interaction with telescope. Thus, I don't see why they should be shared. Yes, certain parameters are somewhat mutually dependent, but sim_telarray has many more parameters. The reason why two branches would be in the same repo is simply to have one repo (I initially proposed to have actually two repositories, but was advised to have one). Having copied corsika configuration for different sim_telarray tags could be an option, but IMHO it is about the same level disadvantages as the ones you've listed above. |
and speaking of git usage: well, here it is used as a versioned DB... not the original use case, but why not, if it can work pretty well? ;) |
I created the corsika branch and added an input card I used to make a testing of the production for protons.
There are a number of points I would like to clarify for corsika generation:
The text was updated successfully, but these errors were encountered: