Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Review this package in light of gammapy recent developments #3

Open
HealthyPear opened this issue Feb 29, 2024 · 6 comments
Open

Review this package in light of gammapy recent developments #3

HealthyPear opened this issue Feb 29, 2024 · 6 comments
Labels
discussion gammapy help wanted Extra attention is needed

Comments

@HealthyPear
Copy link
Member

HealthyPear commented Feb 29, 2024

Since the original script was developed, gammapy evolved quite a bit.

At some point we should review the entire package to see if we can substitute some features with gammapy and/or integrate some more advanced features.

@HealthyPear HealthyPear added help wanted Extra attention is needed discussion labels Feb 29, 2024
@HealthyPear
Copy link
Member Author

HealthyPear commented Sep 13, 2024

This would basically entail to not use the current scripts, but the gammapy API top use the IRF of the instrument which the user wants to use for the proposal and run an estimation of the flux / sky map

@HealthyPear HealthyPear pinned this issue Sep 19, 2024
@HealthyPear
Copy link
Member Author

OK I am splitting this issue in smaller ones after the first tests:

  • I have a working version from MAGIC point-like DL3 observations (gammapy dataset) for the estimation of 1D spectrum but no events
  • same from CTA example irfs from gammapy
  • I tested gammapy.data.ObservationsEventsSampler and with some fixes it is possible to simulate observations based on full-enclosure IRFs and possible perform the full 3D estimation analysis

@HealthyPear
Copy link
Member Author

The configuration system might be very low-level at the beginning, but I am trying to use the same configuration schema as provided by gammapy's high-level interface.

Unfortunately this issue upstream prevents us to use it in one go - that would be awesome.

@HealthyPear
Copy link
Member Author

ObservationsEventsSampler is not contemplated directly in the HLI of gammapy, but if we write to file the fake observation then it should work out of the box!

@HealthyPear
Copy link
Member Author

gammapy devs explained me that ObservationsEventsSampler is not really needed unless for data challenges or time-variable data

in fact simulating a 3D map dataset already allows to get events sampled in the fov from just faking the dataset counts

the only limitation that seems to be remaining is doing a plot like the one in this tutorial section when we do not have simulated events, but just counts from an on/off spectrum dataset

@HealthyPear
Copy link
Member Author

An additional check that I want to add is for the target source altazimutal trajectory against the same coordinates valid fro the IRFs input by the user

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
discussion gammapy help wanted Extra attention is needed
Projects
None yet
Development

No branches or pull requests

1 participant