Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

NodeRemove will allow svnadmin load to commit a transaction when NodeRemove throws an exception #33

Open
cstroe opened this issue Oct 18, 2015 · 1 comment

Comments

@cstroe
Copy link
Owner

cstroe commented Oct 18, 2015

NodeRemove should fail earlier, so that svnadmin load does not commit the transaction.

@cstroe
Copy link
Owner Author

cstroe commented Oct 18, 2015

This would require some look ahead sort of functionality, or some way to have NodeRemove hold back a few bytes of the output buffer until it was sure that it didn't find the node it was looking for.

Look ahead functionality is not feasable, since nodes can be very large.

Holding back a few bytes from the output buffer would require some extra API for SvnDumpWriter, to tell it to hold back bytes, and to tell it to flush the buffer. It's possible that some implementation of OutputStream already does this.

It may be possible to hold back just the endNode() method, in which case this would be the simplest solution.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant