postcss-bundler
#1090
Merged
postcss-bundler
#1090
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
romainmenke
commented
Aug 21, 2023
There was a problem hiding this comment.
This currently only contains some minimal tests, not the full test suite from : https://github.com/romainmenke/css-import-tests
I will add that in a separate PR, because it's just so much and it makes it near impossible to review this.
| import postcssRebaseURL from '@csstools/postcss-rebase-url'; | ||
|
|
||
| /** postcss-bundler plugin options */ | ||
| export type pluginOptions = never; |
There was a problem hiding this comment.
If useful we can add a features option here in the same style as postcss-preset-env.
Allowing users to enable or disable specific features that do or don't apply to them and their setup.
In the beginning however I want to see how useful it is without any config at all.
Antonio-Laguna
approved these changes
Aug 24, 2023
|
Thank you for reviewing all this 🙇 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
part of #1060
A plugin pack for bundling CSS
The goal is to pass these tests and to do for bundling CSS what
postcss-preset-envdoes for fallbacks.It uses :
postcss-importurl()valuesI don't intend to include things best left to other tools :
/distfolderIt is better if this tool adheres to these principles :
postcss-importI initially hoped to be able to use
postcss-importdirectly, but even after fully rewriting that plugin I am still not where I need/want to be. We would still need to override any and every possible thing to make it compatible with the goals I laid out here.I think it is better to do a hard fork and strip out all the parts we don't intend to use.
After doing this work, I found it was much easier to correctly fix the last remaining issues to pass all tests.