Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add time_stamp to closures model #183

Open
nullcount opened this issue Dec 12, 2022 · 3 comments
Open

add time_stamp to closures model #183

nullcount opened this issue Dec 12, 2022 · 3 comments
Labels
enhancement New feature or request

Comments

@nullcount
Copy link

the closures model currently only has a block height in which the closing transaction was confirmed. It should also include the timestamp of the mined block. Onchain txs model includes a timestamp so this model should as well.

It would greatly simplify my usecase. Today, I have to query the node for the timestamp of the block for every closure.

@cryptosharks131
Copy link
Owner

We may be able to attempt to get the timestamp from API data and have it populate if the API is working (similar to close fees). Unfortunately LND is not passing the timestamp back so we are unable to get it directly from the node.

@cryptosharks131 cryptosharks131 added the enhancement New feature or request label Dec 12, 2022
@nullcount
Copy link
Author

My thought was to cross reference with the timestamp from onchain api, but only some channel closures have a corresponding onchain event. I thought every channel closure would have an onchain event. Why is that?

@cryptosharks131
Copy link
Owner

I believe only the channels you open yourself will show a tx in the LND onchain events.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants